Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert CppIn/Out/Ref/Var-Ports #297

Merged
merged 38 commits into from
Aug 18, 2022
Merged

Convert CppIn/Out/Ref/Var-Ports #297

merged 38 commits into from
Aug 18, 2022

Conversation

seowwj
Copy link

@seowwj seowwj commented Aug 10, 2022

Issue Number:

Objective of pull request: Convert the messaging infrastructure to C++ from Python

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@seowwj seowwj marked this pull request as ready for review August 10, 2022 08:48
@hexu33 hexu33 marked this pull request as draft August 11, 2022 02:17
@hexu33 hexu33 marked this pull request as ready for review August 11, 2022 02:17
@seowwj seowwj mentioned this pull request Aug 11, 2022
Closed
16 tasks
@hexu33 hexu33 requested a review from killight98 August 11, 2022 08:00
@hexu33 hexu33 self-requested a review August 11, 2022 08:25
@killight98
Copy link

@seowwj
pls add pythonwrapper interfaces of Ports into src/lava/magma/runtime/message_infrastructure/message_infrastructure/csrc/message_infrastructure_py_wrapper.cc.

@seowwj seowwj requested a review from hexu33 August 15, 2022 06:48
@seowwj
Copy link
Author

seowwj commented Aug 15, 2022

@seowwj pls add pythonwrapper interfaces of Ports into src/lava/magma/runtime/message_infrastructure/message_infrastructure/csrc/message_infrastructure_py_wrapper.cc.

@killight98 @hongdami
Question about virtual functions and porting to the PyWrapper: Do we have to define them, or do we leave it out in the wrapper?

@hexu33
Copy link
Contributor

hexu33 commented Aug 15, 2022

@seowwj pls add pythonwrapper interfaces of Ports into src/lava/magma/runtime/message_infrastructure/message_infrastructure/csrc/message_infrastructure_py_wrapper.cc.

@killight98 @hongdami Question about virtual functions and porting to the PyWrapper: Do we have to define them, or do we leave it out in the wrapper?

Classes with virtual functions do not need to be wrapped. Only abstract class has virtual functions and they do not need to be wrapped into Python.

@killight98
Copy link

@seowwj @shaline-koh
pls add abstract_port_implementation.cc, ports.cc and transformer.cc into CMakeLists.txt.

@shaline-koh shaline-koh merged commit 4fe5a70 into lava-nc:messaging_refactor_develop Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexu33 hexu33 hexu33 approved these changes

@killight98 killight98 killight98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seowwj @killight98 @hexu33 @shaline-koh